> > Device is the same, so maybe its enough to update the name > > in nft_hooks structure? > > You're putting the cart before the horse here: The user sets > hook->ifname and we bind to whatever device matches that. > > Now with a device being renamed, there are two options: > > A) Unbind if the name doesn't match hook->ifname anymore and search for > another, matching hook. This is what I had (tried to) implement. > > B) Just leave the interface in place as long as it exists. This is how > the old code behaves. > > For users, I find (A) more intuitive. Yes, that makes sense to me. But can't you defer the unbind until after you've figured out if there is a matching hook or not? I.e., if no matching new hook, just unreg, else register new/unregister old. Otherwise, we might unreg, then fail to re-register?
