On Sat, Sep 07, 2024 at 02:48:37PM +0100, Simon Horman wrote: > On Fri, Sep 06, 2024 at 05:55:13PM +0300, Andy Shevchenko wrote: > As mentioned in relation to another similar patch, > I'm not sure that resolution of W=1 warnings are fixes. Up to you, I consider they as fixes as I'm pretty much annoyed each release to have disable CONFIG_WERROR. But I got your point. ... > Possibly it is broken for some reason - like reading nskb too late - > but I wonder if rather than annotating niph it's scope can be reduced > to the code that is only compiled if CONFIG_BRIDGE_NETFILTER is enabled. > > This also addreses what appears to be an assingment of niph without > the value being used - the first assingment. > > E.g., for the ipv4 case (compile tested only!): Please, submit a formal patch, I'm not so familiar with the guts of networking core to be able to produce anything better than I already did. Consider this as Reported-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Thank you! -- With Best Regards, Andy Shevchenko
