Hi Florian, kernel test robot noticed the following build errors: [auto build test ERROR on netfilter-nf/main] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/netfilter-nft_socket-make-cgroupsv2-matching-work-with-namespaces/20240905-185930 base: https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main patch link: https://lore.kernel.org/r/20240905105451.28857-2-fw%40strlen.de patch subject: [PATCH nf 2/2] netfilter: nft_socket: make cgroupsv2 matching work with namespaces config: arm-randconfig-002-20240907 (https://download.01.org/0day-ci/archive/20240907/202409070305.pBDk8EVS-lkp@xxxxxxxxx/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240907/202409070305.pBDk8EVS-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202409070305.pBDk8EVS-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): net/netfilter/nft_socket.c: In function 'nft_socket_init': >> net/netfilter/nft_socket.c:212:23: error: implicit declaration of function 'nft_socket_cgroup_subtree_level' [-Wimplicit-function-declaration] 212 | err = nft_socket_cgroup_subtree_level(); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/nft_socket_cgroup_subtree_level +212 net/netfilter/nft_socket.c 169 170 static int nft_socket_init(const struct nft_ctx *ctx, 171 const struct nft_expr *expr, 172 const struct nlattr * const tb[]) 173 { 174 struct nft_socket *priv = nft_expr_priv(expr); 175 unsigned int len; 176 177 if (!tb[NFTA_SOCKET_DREG] || !tb[NFTA_SOCKET_KEY]) 178 return -EINVAL; 179 180 switch(ctx->family) { 181 case NFPROTO_IPV4: 182 #if IS_ENABLED(CONFIG_NF_TABLES_IPV6) 183 case NFPROTO_IPV6: 184 #endif 185 case NFPROTO_INET: 186 break; 187 default: 188 return -EOPNOTSUPP; 189 } 190 191 priv->key = ntohl(nla_get_be32(tb[NFTA_SOCKET_KEY])); 192 switch(priv->key) { 193 case NFT_SOCKET_TRANSPARENT: 194 case NFT_SOCKET_WILDCARD: 195 len = sizeof(u8); 196 break; 197 case NFT_SOCKET_MARK: 198 len = sizeof(u32); 199 break; 200 #ifdef CONFIG_CGROUPS 201 case NFT_SOCKET_CGROUPV2: { 202 unsigned int level; 203 int err; 204 205 if (!tb[NFTA_SOCKET_LEVEL]) 206 return -EINVAL; 207 208 level = ntohl(nla_get_be32(tb[NFTA_SOCKET_LEVEL])); 209 if (level > 255) 210 return -EOPNOTSUPP; 211 > 212 err = nft_socket_cgroup_subtree_level(); 213 if (err < 0) 214 return err; 215 216 priv->level_user = level; 217 218 level += err; 219 /* Implies a giant cgroup tree */ 220 if (WARN_ON_ONCE(level > 255)) 221 return -EOPNOTSUPP; 222 223 priv->level = level; 224 len = sizeof(u64); 225 break; 226 } 227 #endif 228 default: 229 return -EOPNOTSUPP; 230 } 231 232 priv->len = len; 233 return nft_parse_register_store(ctx, tb[NFTA_SOCKET_DREG], &priv->dreg, 234 NULL, NFT_DATA_VALUE, len); 235 } 236 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
