On Thu, Aug 29, 2024 at 01:04:46PM +0100, Joshua Lant wrote: > > Thanks for the patch! I tested and it may be simplified a bit: > > > > [...] > > > + #if defined(__UAPI_DEF_ETHHDR) && __UAPI_DEF_ETHHDR == 0 > > > + return 0; > > > + #else > > > + #error error trying musl... > > > + #endif > > [...] > > > > Since the non-failure case is the default, this is sufficient: > > > > | #if ! defined(__UAPI_DEF_ETHHDR) || __UAPI_DEF_ETHHDR != 0 > > | #error error trying musl... > > | #endif > > > > Fine with you? If so, I'll push the modified patch out. > > > > Thanks, Phil > > Looks good to me :) Thanks for your review, modified patch applied. Thanks, Phil
