[PATCH net-next 00/12] Unmask upper DSCP bits - part 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tl;dr - This patchset starts to unmask the upper DSCP bits in the IPv4
flow key in preparation for allowing IPv4 FIB rules to match on DSCP. No
functional changes are expected.

The TOS field in the IPv4 flow key ('flowi4_tos') is used during FIB
lookup to match against the TOS selector in FIB rules and routes.

It is currently impossible for user space to configure FIB rules that
match on the DSCP value as the upper DSCP bits are either masked in the
various call sites that initialize the IPv4 flow key or along the path
to the FIB core.

In preparation for adding a DSCP selector to IPv4 and IPv6 FIB rules, we
need to make sure the entire DSCP value is present in the IPv4 flow key.
This patchset starts to unmask the upper DSCP bits in the various places
that invoke the core FIB lookup functions directly (patches #1-#7) and
in the input route path (patches #8-#12). Future patchsets will do the
same in the output route path.

No functional changes are expected as commit 1fa3314c14c6 ("ipv4:
Centralize TOS matching") moved the masking of the upper DSCP bits to
the core where 'flowi4_tos' is matched against the TOS selector.

Ido Schimmel (12):
  bpf: Unmask upper DSCP bits in bpf_fib_lookup() helper
  ipv4: Unmask upper DSCP bits in NETLINK_FIB_LOOKUP family
  ipv4: Unmask upper DSCP bits when constructing the Record Route option
  netfilter: rpfilter: Unmask upper DSCP bits
  netfilter: nft_fib: Unmask upper DSCP bits
  ipv4: ipmr: Unmask upper DSCP bits in ipmr_rt_fib_lookup()
  ipv4: Unmask upper DSCP bits in fib_compute_spec_dst()
  ipv4: Unmask upper DSCP bits in input route lookup
  ipv4: Unmask upper DSCP bits in RTM_GETROUTE input route lookup
  ipv4: icmp: Pass full DS field to ip_route_input()
  ipv4: udp: Unmask upper DSCP bits during early demux
  ipv4: Unmask upper DSCP bits when using hints

 net/core/filter.c                 | 3 ++-
 net/ipv4/fib_frontend.c           | 4 ++--
 net/ipv4/icmp.c                   | 2 +-
 net/ipv4/ipmr.c                   | 3 ++-
 net/ipv4/netfilter/ipt_rpfilter.c | 3 ++-
 net/ipv4/netfilter/nft_fib_ipv4.c | 3 ++-
 net/ipv4/route.c                  | 8 ++++----
 net/ipv4/udp.c                    | 3 ++-
 8 files changed, 17 insertions(+), 12 deletions(-)

-- 
2.46.0





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux