On Fri, 19 Jul 2024 13:19:26 +0200
Florian Westphal <fw@xxxxxxxxx> wrote:
> We need to disable softinterrupts, else we get following problem:
>
> 1. pipapo_avx2 called from process context; fpu usable
> 2. preempt_disable() called, pcpu scratchmap in use
> 3. softirq handles rx or tx, we re-enter pipapo_avx2
> 4. fpu busy, fallback to generic non-avx version
> 5. fallback reuses scratch map and index, which are in use
> by the preempted process
Oops.
> Handle this same way as generic version by first disabling
> softinterrupts while the scratchmap is in use.
>
> Fixes: f0b3d338064e ("netfilter: nft_set_pipapo_avx2: Add irq_fpu_usable() check, fallback to non-AVX2 version")
> Cc: Stefano Brivio <sbrivio@xxxxxxxxxx>
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
Reviewed-by: Stefano Brivio <sbrivio@xxxxxxxxxx>
--
Stefano
