Re: [PATCH] xtables: Fix compilation error with musl-libc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Phil,

> Man, this crap keeps popping up. Last time we "fixed" it was in commit
> 0e7cf0ad306cd ("Revert "fix build for missing ETH_ALEN definition"").
> There, including netinet/ether.h was OK. Now it's problematic?
> Interestingly, linux/if_ether.h has this:
> 
> | /* allow libcs like musl to deactivate this, glibc does not implement this. */
> | #ifndef __UAPI_DEF_ETHHDR
> | #define __UAPI_DEF_ETHHDR               1
> | #endif
> 
> So it's not like the other party is ignoring musl's needs. Does adding
> -D__UAPI_DEF_ETHHDR=0 fix the build? Should we maybe add a configure
> option for this instead of shooting the moving target?

Yeah cheers adding that does indeed fix the build...

I have added a configure option. I will submit this as a separate patch.

Thanks,

Josh




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux