Hi Florian, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/net-add-and-use-skb_get_hash_net/20240607-163738 base: net-next/main patch link: https://lore.kernel.org/r/20240607083205.3000-2-fw%40strlen.de patch subject: [PATCH net-next 1/2] net: add and use skb_get_hash_net config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240607/202406072022.OkRGOAuS-lkp@xxxxxxxxx/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240607/202406072022.OkRGOAuS-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202406072022.OkRGOAuS-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> net/core/flow_dissector.c:1872: warning: Function parameter or struct member 'net' not described in '__skb_get_hash_net' vim +1872 net/core/flow_dissector.c eb70db8756717b David S. Miller 2016-07-01 1861 d4fd32757176d1 Jiri Pirko 2015-05-12 1862 /** 11b45a5b56dab6 Florian Westphal 2024-06-07 1863 * __skb_get_hash_net: calculate a flow hash d4fd32757176d1 Jiri Pirko 2015-05-12 1864 * @skb: sk_buff to calculate flow hash from d4fd32757176d1 Jiri Pirko 2015-05-12 1865 * d4fd32757176d1 Jiri Pirko 2015-05-12 1866 * This function calculates a flow hash based on src/dst addresses 61b905da33ae25 Tom Herbert 2014-03-24 1867 * and src/dst port numbers. Sets hash in skb to non-zero hash value 61b905da33ae25 Tom Herbert 2014-03-24 1868 * on success, zero indicates no valid hash. Also, sets l4_hash in skb 441d9d327f1e77 Cong Wang 2013-01-21 1869 * if hash is a canonical 4-tuple hash over transport ports. 441d9d327f1e77 Cong Wang 2013-01-21 1870 */ 11b45a5b56dab6 Florian Westphal 2024-06-07 1871 void __skb_get_hash_net(const struct net *net, struct sk_buff *skb) 441d9d327f1e77 Cong Wang 2013-01-21 @1872 { 441d9d327f1e77 Cong Wang 2013-01-21 1873 struct flow_keys keys; 635c223cfa05af Gao Feng 2016-08-31 1874 u32 hash; 441d9d327f1e77 Cong Wang 2013-01-21 1875 11b45a5b56dab6 Florian Westphal 2024-06-07 1876 memset(&keys, 0, sizeof(keys)); 11b45a5b56dab6 Florian Westphal 2024-06-07 1877 11b45a5b56dab6 Florian Westphal 2024-06-07 1878 __skb_flow_dissect(net, skb, &flow_keys_dissector, 11b45a5b56dab6 Florian Westphal 2024-06-07 1879 &keys, NULL, 0, 0, 0, 11b45a5b56dab6 Florian Westphal 2024-06-07 1880 FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL); 11b45a5b56dab6 Florian Westphal 2024-06-07 1881 50fb799289501c Tom Herbert 2015-05-01 1882 __flow_hash_secret_init(); 50fb799289501c Tom Herbert 2015-05-01 1883 11b45a5b56dab6 Florian Westphal 2024-06-07 1884 hash = __flow_hash_from_keys(&keys, &hashrnd); 635c223cfa05af Gao Feng 2016-08-31 1885 635c223cfa05af Gao Feng 2016-08-31 1886 __skb_set_sw_hash(skb, hash, flow_keys_have_l4(&keys)); 441d9d327f1e77 Cong Wang 2013-01-21 1887 } 11b45a5b56dab6 Florian Westphal 2024-06-07 1888 EXPORT_SYMBOL(__skb_get_hash_net); 441d9d327f1e77 Cong Wang 2013-01-21 1889 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
