On Wed, Jun 05, 2024 at 08:14:50PM +0200, Florian Westphal wrote: > Christoph Paasch <cpaasch@xxxxxxxxx> wrote: > > > Reported-by: Christoph Paasch <cpaasch@xxxxxxxxx> > > > Suggested-by: Paolo Abeni <pabeni@xxxxxxxxxx> > > > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/494 > > > Signed-off-by: Florian Westphal <fw@xxxxxxxxx> > > > > I just gave this one a shot in my syzkaller instances and am still hitting the issue. > > No, different bug, this patch is correct. > > I refuse to touch the flow dissector. I see callers of ip_local_out() in the tree which do not set skb->dev. I don't understand this: bool __skb_flow_dissect(const struct net *net, const struct sk_buff *skb, struct flow_dissector *flow_dissector, void *target_container, const void *data, __be16 proto, int nhoff, int hlen, unsigned int flags) { [...] WARN_ON_ONCE(!net); if (net) { it was added by 9b52e3f267a6 ("flow_dissector: handle no-skb use case") Is this WARN_ON_ONCE() bogus?
