On Tue, 4 Jun 2024 12:27:06 +0300, Dan Carpenter wrote: > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Lizhi-Xu/ext4-check-hash-version-and-filesystem-casefolded-consistent/20240531-170046 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > patch link: https://lore.kernel.org/r/20240531085647.2918240-1-lizhi.xu%40windriver.com > patch subject: [PATCH V3] ext4: check hash version and filesystem casefolded consistent > config: i386-randconfig-141-20240601 (https://download.01.org/0day-ci/archive/20240602/202406020752.Ii2MU4KP-lkp@xxxxxxxxx/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > | Closes: https://lore.kernel.org/r/202406020752.Ii2MU4KP-lkp@xxxxxxxxx/ > > smatch warnings: > fs/ext4/super.c:5287 __ext4_fill_super() warn: missing error code 'err' > > vim +/err +5287 fs/ext4/super.c > > d4fab7b28e2f5d7 Theodore Ts'o 2023-04-27 5280 err = ext4_block_group_meta_init(sb, silent); > d4fab7b28e2f5d7 Theodore Ts'o 2023-04-27 5281 if (err) > 0d1ee42f27d30ee Alexandre Ratchov 2006-10-11 5282 goto failed_mount; > 0b8e58a140cae2b Andreas Dilger 2009-06-03 5283 > db9345d9e6f075e Jason Yan 2023-03-23 5284 ext4_hash_info_init(sb); > 66b3f078839bbdb Lizhi Xu 2024-05-31 5285 if (es->s_def_hash_version == DX_HASH_SIPHASH && > 66b3f078839bbdb Lizhi Xu 2024-05-31 5286 !ext4_has_feature_casefold(sb)) > 66b3f078839bbdb Lizhi Xu 2024-05-31 @5287 goto failed_mount; This warning has been resolved in the following patch: https://lore.kernel.org/all/20240601113749.473058-1-lizhi.xu@xxxxxxxxxxxxx/ Lizhi