> -----Original Message----- > From: Florian Westphal [mailto:fw@xxxxxxxxx] > Sent: Thursday, May 30, 2024 3:52 PM > To: wangyunjian <wangyunjian@xxxxxxxxxx> > Cc: Florian Westphal <fw@xxxxxxxxx>; netfilter-devel@xxxxxxxxxxxxxxx; > pablo@xxxxxxxxxxxxx; kadlec@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; > davem@xxxxxxxxxxxxx; coreteam@xxxxxxxxxxxxx; xudingke > <xudingke@xxxxxxxxxx> > Subject: Re: [PATCH net] netfilter: nf_conncount: fix wrong variable type > > wangyunjian <wangyunjian@xxxxxxxxxx> wrote: > > > -----Original Message----- > > > From: Florian Westphal [mailto:fw@xxxxxxxxx] > > > Sent: Wednesday, May 29, 2024 8:03 PM > > > To: wangyunjian <wangyunjian@xxxxxxxxxx> > > > Cc: netfilter-devel@xxxxxxxxxxxxxxx; pablo@xxxxxxxxxxxxx; > kadlec@xxxxxxxxxxxxx; > > > kuba@xxxxxxxxxx; davem@xxxxxxxxxxxxx; coreteam@xxxxxxxxxxxxx; > xudingke > > > <xudingke@xxxxxxxxxx> > > > Subject: Re: [PATCH net] netfilter: nf_conncount: fix wrong variable type > > > > > > Yunjian Wang <wangyunjian@xxxxxxxxxx> wrote: > > > > 'keylen' is supposed to be unsigned int, not u8, so fix it. > > > > > > Its limited to 5, so u8 works fine. > > > > Currently, it does not affect the functionality. The main issue is that code > > checks will report a warning: implicit narrowing conversion from type > > 'unsigned int' to small type 'u8'. > > Then please quote the exact warning in the commit message and remove the > u8 temporary variable in favor of data->keylen. OK, I will update it. This is not a bugfix, only considered for net-next? Thanks.
