Re: [PATCH net] netfilter: nfnetlink_queue: acquire rcu_read_lock() in instance_destroy_rcu()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
> > If you prefer Erics patch thats absolutely fine with me, I'll rebase in
> > that case to keep the selftest around.
> 
> I missed your patch, otherwise I would have done nothing ;)
> 
> I saw the recent changes about nf_reinject() and tried to have a patch
> that would be easily backported without conflicts.

Right, makes sense from that pov.
I think its fine to apply the patch in this case, I'll followup later.

Thus:
Acked-by: Florian Westphal <fw@xxxxxxxxx>

> Do you think the splat is caused by recent changes, or is it simply
> syzbot getting smarter ?

Its old bug, AFAICS your Fixes tag is correct.

1. Userspace prog needs to subscribe to queue x
2. iptables/nftables rule needs to send packets to queue x
3. actual packets that match that have to be sent
4. Userspace program needs to exit while at least one packet
   is queued

Amazing that syzbot managed to hit all 4 checkboxes :)





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux