Hi Jason, On Fri, Mar 29, 2024 at 08:33:32PM +0800, Jason Xing wrote: > On Mon, Mar 25, 2024 at 8:36 PM Jason Xing <kerneljasonxing@xxxxxxxxx> wrote: > > > > From: Jason Xing <kernelxing@xxxxxxxxxxx> > > > > At the beginning in 2009 one patch [1] introduced collecting drop > > counter in nf_conntrack_in() by returning -NF_DROP. Later, another > > patch [2] changed the return value of tcp_packet() which now is > > renamed to nf_conntrack_tcp_packet() from -NF_DROP to NF_DROP. As > > we can see, that -NF_DROP should be corrected. > > > > Similarly, there are other two points where the -NF_DROP is used. > > > > Well, as NF_DROP is equal to 0, inverting NF_DROP makes no sense > > as patch [2] said many years ago. > > > > [1] > > commit 7d1e04598e5e ("netfilter: nf_conntrack: account packets drop by tcp_packet()") > > [2] > > commit ec8d540969da ("netfilter: conntrack: fix dropping packet after l4proto->packet()") > > > > Signed-off-by: Jason Xing <kernelxing@xxxxxxxxxxx> > > Hello Pablo, > > I don't know how it works in the nf area, so I would like to know the > status of this patch and another one (netfilter: conntrack: dccp: try > not to drop skb in conntrack > )? Is there anything I need to change? No action on your side, I will start collecting pending material for nf-next next week. Thanks for your patience.