Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > AFAICS this means that if the table as udata attached, and userspace > > makes an update request without a UDATA netlink attribute, we will > > delete the existing udata. > > > > Is that right? > > > > My question is, should we instead leave the existing udata as-is and not > > support removal, only replace? > > I would leave it in place too if no _USERDATA is specified. > > One more question is if the memcmp() with old and new udata makes > sense considering two consecutive requests for _USERDATA update in one > batch. Great point, any second udata change request in the same batch must fail. We learned this the hard way with flag updates :(