Re: [PATCH xtables] extensions: xt_TPROXY: add txlate support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phil Sutter <phil@xxxxxx> wrote:
> Could you please add a testcase involving an IPv6 address? Just so we
> exercise this code path.

done.

> > +	else if (mask || info->mark_value)
> > +		xt_xlate_add(xl, "meta mark set meta mark & 0x%x or 0x%x",
> > +			     ~mask, info->mark_value);
> 
> Shouldn't this be 'xor' instead of 'or' in translated output?

Makes no difference.  But I see that this might be confusing when
looking at xt_TPROXY.c or the comment so I changed it.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux