On Wed, Mar 06, 2024 at 04:42:07PM +0100, Florian Westphal wrote: > Phil Sutter <phil@xxxxxx> wrote: > > On Wed, Mar 06, 2024 at 11:11:25AM +0100, Florian Westphal wrote: > > > +static int socket_mt_xlate(struct xt_xlate *xl, const struct xt_xlate_mt_params *params) > > > +{ > > > + const struct xt_socket_mtinfo3 *info = (const void *)params->match->data; > > > + const char *space = ""; > > > > The whole "leading space or not" handling is not necessary, I made > > xt_xlate_add() insert leading space automatically if the first > > character is alpha-numeric or a brace. > > Perfect, I'll push this out after removing the extra handling. Acked-by: Phil Sutter <phil@xxxxxx>