Re: [PATCH v2 nf-next 0/4] netfilter: nft_set_pipapo: speed up bulk element insertions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 13 Feb 2024 16:23:36 +0100
Florian Westphal <fw@xxxxxxxxx> wrote:

> v2: addressed comments from Stefano, see patches for details.
> 
> Bulk insertions into pipapo set type take a very long time, each new
> element allocates space for elem+1 elements, then copies all existing
> elements and appends the new element.
> 
> Alloc extra slack space to reduce the realloc overhead to speed this up.
> 
> While at it, shrink a few data structures, in may cases a much smaller
> type can be used.
> 
> Florian Westphal (4):
>   netfilter: nft_set_pipapo: constify lookup fn args where possible
>   netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR
>   netfilter: nft_set_pipapo: shrink data structures
>   netfilter: nft_set_pipapo: speed up bulk element insertions

For the series,

Reviewed-by: Stefano Brivio <sbrivio@xxxxxxxxxx>

-- 
Stefano





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux