On Tue, 6 Feb 2024 13:23:07 +0100 Florian Westphal <fw@xxxxxxxxx> wrote: > After next patch simple kfree() is not enough anymore, so add > a helper for it. > > Signed-off-by: Florian Westphal <fw@xxxxxxxxx> > --- > net/netfilter/nft_set_pipapo.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c > index a8aa915f3f0b..3d308e31b048 100644 > --- a/net/netfilter/nft_set_pipapo.c > +++ b/net/netfilter/nft_set_pipapo.c > @@ -1108,6 +1108,19 @@ static void pipapo_map(struct nft_pipapo_match *m, > f->mt[map[i].to + j].e = e; > } > > +static void pipapo_free_scratch(const struct nft_pipapo_match *m, unsigned int cpu) Almost everything else here has kerneldoc-style comments, perhaps (already accounting for 3/3): /** * pipapo_free_scratch() - Free per-CPU map at original (not aligned) address * @m: Matching data * @cpu: CPU number */ Other than this, Reviewed-by: Stefano Brivio <sbrivio@xxxxxxxxxx> -- Stefano