Re: [iptables PATCH 07/23] extensions: libebt_stp: Use guided option parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Dec 20, 2023 at 08:29:25PM +0100, Jan Engelhardt wrote:
> On Wednesday 2023-12-20 17:06, Phil Sutter wrote:
> >index 17d6c1c0978e3..b3c7e5f3aa8f3 100644
> >--- a/extensions/libebt_stp.t
> >+++ b/extensions/libebt_stp.t
> >@@ -1,13 +1,29 @@
> > --stp-type 1;=;OK
> >+--stp-type ! 1;=;OK
> Is this the normal syntax for .t files, or should this be
> `! --stp-stype 1` to avoid the infamous "Using intrapositional negation" warning?

With ebtables, intrapositioned negations are still the default although
extrapositioned ones are accepted. For the tests, I chose to use the
former just so I could use '=' in place of expected output.

Since ebtables-nft now uses the xshared commandline parser, it will
indeed complain about these intrapositioned negations. Guess the time
has come to change how ebtables prints rules and to adjust the test
cases accordingly. Thanks for the reminder!

Cheers, Phil

[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux