Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > if (!desc) {
> > - if (field != TCPOPT_COMMON_KIND || kind > 255)
> > + if (kind > 255)
> > return NULL;
>
> Another suggestion: Remove this NULL, it leaves lhs as NULL in the
> relational. kind > 255 cannot ever happen, parser rejects numbers over
> 255.
We can also feed this via input from udata (typeof).
So I'd rather not assert() or rely on bison checks.
