On Sat, Nov 25, 2023 at 08:26:01AM +0000, Simon Horman wrote: > On Thu, Nov 23, 2023 at 03:10:51PM +0100, Florian Westphal wrote: > > Simon Horman <horms@xxxxxxxxxx> wrote: > > > > - err = nf_flow_table_init(&ct_ft->nf_ft); > > > > + ct_ft->nf_ft = kzalloc(sizeof(*ct_ft->nf_ft), GFP_KERNEL); > > > > + if (!ct_ft->nf_ft) > > > > + goto err_alloc; > > > > > > Hi Florian, > > > > > > This branch will cause the function to return err, but err is 0 here. > > > Perhaps it should be set to a negative error value instead? > > > > Yes, this should fail with -ENOMEM. > > Thanks, I will send a patch. Ooops, for some reason I thought this had been accepted, but I don't see it in nf-next. So I guess I don't need to send a patch for now.
