Help text printing code does not refer to optarg, so there is no need to assign to it if unset. Signed-off-by: Phil Sutter <phil@xxxxxx> --- iptables/xshared.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/iptables/xshared.c b/iptables/xshared.c index 5f75a0a57a023..53e72b7abb1e8 100644 --- a/iptables/xshared.c +++ b/iptables/xshared.c @@ -1527,9 +1527,6 @@ void do_parse(int argc, char *argv[], break; case 'h': - if (!optarg) - optarg = argv[optind]; - /* iptables -p icmp -h */ if (!cs->matches && cs->protocol) xtables_find_match(cs->protocol, -- 2.41.0
