Hi Thomas, On Tue, Nov 21, 2023 at 01:10:11PM +0100, Thomas Haller wrote: > On Sat, 2023-11-18 at 03:36 +0100, Phil Sutter wrote: > > On Fri, Nov 17, 2023 at 06:18:45PM +0100, Thomas Haller wrote: [...] > > > Note that only a few .json-nft files are adjusted, because > > > otherwise the > > > patch is too large. Before applying, you need to adjust them all, > > > by > > > running `./tests/shell/run-tests.sh -g`. > > > > Just put the bulk change into a second patch? > > it would require 3 patches to stay below the limit. > > Also, it blows up the inbox by everybody on the list by 850K (57k > gzipped). The rest of the patch is generated. Just generate it. Excuse for jumping through this, just a submission style notice: Please, Cc maintainers with big patches that don't fit in into the mailing list in the future. > Alternatively, > > git fetch https://gitlab.freedesktop.org/thaller/nftables df984038a33c6da5b159e6f6458351c4fa673bf1 > git merge FETCH_HEAD I'd suggest you place this also in the cover letter, so at least there is a record on the mailing list archive that some patches could not get through but there was an alternative way to take them for others. As for maintainers, they can collect the large patch as attachment from the email. Thanks.
