On Wed, Nov 15, 2023 at 11:25:44AM +0100, Thomas Haller wrote: > On Wed, 2023-11-15 at 10:42 +0100, Pablo Neira Ayuso wrote: > > > > > > +if [ "$NFT_TEST_HAVE_pipapo" != y ] ;then > > + echo "Skipping pipapo set backend, kernel does not support > > it" > > +fi > > It's good and useful to run a reduced subset of the test, if some > kernel feature is missing. > > But in that case, the end of the test should have something like > > if [ "$NFT_TEST_HAVE_pipapo" = n ] ; then > echo "Ran a partial test only, due to NFT_TEST_HAVE_pipapo=n" > exit 77 > fi > > so that it shows up as skipped. In other words, "partially skipped" > should also show up as skipped. I don't want this. This test is very useful in older kernels to catch bugs, I don't want to see a SKIPPED here. I prefer the tests autoadapts itself to what the kernel provides.
