On Wed, Nov 15, 2023 at 11:01:01AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > On Wed, Nov 15, 2023 at 09:24:27AM +0100, Florian Westphal wrote:
> > > Thomas Haller <thaller@xxxxxxxxxx> wrote:
> > > > The rules after a successful test are good opportunity to test
> > > > `nft -j list ruleset` and `nft -j --check`. This quite possibly touches
> > > > code paths that are not hit by other tests yet.
> > >
> > > This series looks good to me, I'll apply it in the next few hours if
> > > noone else takes any action by then.
> >
> > Just a question, patch 3 is missing in patchwork. I guess it is too
> > big.
> >
> > My understanding is that this performs the json tests if nft comes with
> > json support.
> >
> > I wanted to give this a run, description says a few tests are failing.
>
> ... but it says that no dump files are added for the failing test cases.
OK. Then json it is skipped in that case, that is fine.
> I'll double check this of course before pushing this out.
Then, please also disable json dump by now for:
sets/sets_with_ifnames
because I am currently figuring out how to detach pipapo support from
it without losing coverage.
