Re: [PATCH nft 01/12] tests: shell: export DIFF to use it from feature scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2023-11-09 at 17:22 +0100, Pablo Neira Ayuso wrote:
> export DIFF so it can be used from feature scripts to probe the
> kernel.
> 
> +DIFF="$(which diff)"
> +if [ ! -x "$DIFF" ] ; then
> +	DIFF=true
> +fi
> +export DIFF


what is the purpose of having $DIFF variable at all?
Why not require to have `diff` installed?


Maybe that justification is somewhere in the history of the project. If
so, could you drop one line in the commit message what the point is?


Thomas





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux