On Fri, 2023-11-03 at 17:46 +0100, Pablo Neira Ayuso wrote:
> On Fri, Nov 03, 2023 at 05:25:14PM +0100, Thomas Haller wrote:
> > diff --git a/src/statement.c b/src/statement.c
> > index f5176e6d87f9..d52b01b9099a 100644
> > --- a/src/statement.c
> > +++ b/src/statement.c
> > @@ -141,6 +141,7 @@ static const struct stmt_ops chain_stmt_ops = {
> > .type = STMT_CHAIN,
> > .name = "chain",
> > .print = chain_stmt_print,
> > + .json = NULL, /* BUG: must be implemented! */
>
> This is a bit starting the house from the roof.
>
> Better fix this first, so this ugly patch does not need to be
> applied.
>
that is going to take a while.
The patches to enable more JSON tests find other issues (and are
ready). Also, implementing a not-entirely-trivial feature
(chain_stmt_ops.json) without the JSON tests in place, is unnecessarily
backwards.
If you dislike the code comments, please drop them. But this
`fprintf()` should go, as spams stderr and [1] checks against that.
That check is useful to find bugs.
[1] https://marc.info/?l=netfilter-devel&m=169877835315739&w=2
Thomas
