Re: [PATCH nft 2/2] json: drop handling missing json() hook for "struct expr_ops"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2023-11-02 at 18:39 +0100, Thomas Haller wrote:
> 
> This part of the patch is wrong. Must not be applied.
> 
> 
> stmt->ops is a "struct stmt_ops", which still has NULL "json"
> callbacks. The patch 1/1 only addresses "json" hooks in "struct
> expr_ops".


The NULL pointers in json() hooks are:

in struct expr_ops:

   - symbol_expr_ops
   - variabl_expr_ops

in struct stmt_ops:

   - chain_stmt_ops


The two patches lack handling chain_stmt_ops.json.




Thomas





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux