On Tue, Oct 17, 2023 at 10:49:07AM +0200, Thomas Haller wrote: > The "table_onoff" test can only pass with certain (recent) kernels. > Conditionally exit with status 77, if "eval-exit-code" determines that > we don't have a suitable kernel version. > > In this case, we can find the fixes in: > > v6.6 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c9bd26513b3a11b3adb3c2ed8a31a01a87173ff1 > v6.5.6 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e5754e9e77ce400d70ff3c30fea466c8dfe9a9f > v6.1.56 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c4b0facd5c20ceae3d07018a3417f06302fa9cd1 > v5.15.135 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0dcc9b4097d860d9af52db5366a8755c13468d13 I am not sure it worth this level of tracking. Soon these patches will be in upstream stable and this extra shell code will be simply deadcode in little time. > Fixes: bcca2d67656f ('tests: add test for dormant on/off/on bug') > Signed-off-by: Thomas Haller <thaller@xxxxxxxxxx> > --- > tests/shell/testcases/transactions/table_onoff | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/shell/testcases/transactions/table_onoff b/tests/shell/testcases/transactions/table_onoff > index 831d4614c1f2..0e70ad2cc3f4 100755 > --- a/tests/shell/testcases/transactions/table_onoff > +++ b/tests/shell/testcases/transactions/table_onoff > @@ -11,7 +11,9 @@ delete table ip t > EOF > > if [ $? -eq 0 ]; then > - exit 1 > + echo "Command to re-awaken a dormant table did not fail. Lacking https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c9bd26513b3a11b3adb3c2ed8a31a01a87173ff1 ?" > + "$NFT_TEST_BASEDIR/helpers/eval-exit-code" kernel 6.6 6.5.6 6.1.56 5.15.135 > + exit $? > fi > > set -e > -- > 2.41.0 >
