Re: [PATCH nft 1/3] tests/shell: skip "table_onoff" test if kernel patch is missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Thomas Haller <thaller@xxxxxxxxxx> wrote:
> Passing the test suite must not require latest kernel patches.  If test
> "table_onoff" appears to not work due to a missing kernel patch, skip
> it.
> If you run a special kernel and expect that all test pass, set
> NFT_TEST_FAIL_ON_SKIP=y to catch unexpected skips.

This makes the test suite and all feature probing moot for my use cases.
If I see SKIP, I assume that the feature is missing.

This is a bug, and it tells me that I might have to do something
about it.

If you absolutely cannot have a failure because of this, then
please add another error state for this, so that I can see that
something is wrong.

This is NOT the same as a skip because some distro kernel lacks
anonymous chain support.

That said, I would STRONLGY perfer failure here.
Distros will ship updates that eventually also include this bug fix.

This fix is included in 6.5.6 for example.

[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux