On Wed, Sep 27, 2023 at 09:51:15PM +0200, Thomas Haller wrote: > <string.h> provides strcmp(), as such it's very basic and used > everywhere. > > Include it via <nft.h>. > > The benefit of this will be to add a static-inline function > nft_strcmp0() to <nft.h>, which calls strcmp() but handles that strings > might be NULL. Such a basic utility will be useful, and <nft.h> is the > right place. So we will need <string.h> there. Regardless of that, not > including the same header basically everywhere, is already a benefit. Applied, thanks