Re: [PATCH nft 8/9] datatype: use __attribute__((packed)) instead of enum bitfields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 20, 2023 at 07:48:22PM +0200, Thomas Haller wrote:
> On Wed, 2023-09-20 at 18:02 +0200, Pablo Neira Ayuso wrote:
> > On Wed, Sep 20, 2023 at 04:26:09PM +0200, Thomas Haller wrote:
> > 
> > > +       enum ops                op;
> > 
> > This is saving _a lot of space_ for us, we currently have a problem
> > with memory consumption, this is going in the opposite direction.
> > 
> > I prefer to ditch this patch.
> 
> The packed enums are only one uint8_t large. The memory-saving compared
> to a :8 bitfield is exactly the same.

I see, I am not sure yet I want to give control to the compiler on the
layout of these structures, I have been using pahole to shrink them
further, specifically struct expr is critical (I have at least one
patch to reduce the size of constant expressions to safe % memory with
very 13.5%. And location for error reporting is still consuming 48
bytes per struct expr.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux