Re: [PATCH nft 3/3] tests/shell: run `nft --check` on persisted dump files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Sep 18, 2023 at 09:59:24PM +0200, Thomas Haller wrote:
> "nft --check" will trigger a rollback in kernel. The existing dump files
> might hit new code paths. Take the opportunity to call the command on
> the existing files.
> And alternative would be to write a separate tests, that iterates over
> all files. However, then we can only run all the commands sequentially
> (unless we do something smart). That might be slower than the
> opportunity to run the checks in parallel. More importantly, it would be
> nice if the check for the dump file is clearly tied to the file's test.
> So run it right after the test, from the test wrapper.

I am already using this patch in my tests.

Applied, thanks.

[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux