Re: [ANNOUNCE] ipset 7.18 released

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wednesday 2023-09-20 13:20, Jan Engelhardt wrote:
>On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote:
>>I'm happy to announce ipset 7.18, which brings a few fixes, backports, 
>>tests suite fixes and json output support.
>The installation of the pkgconfig file is now broken.
>>  - lib/ fix pkgconfig dir (Sam James)
>Aaaaagh.. that change completely broke installation and must be reverted.

commit 326932be0c4f47756f9809cad5a103ac310f700d
Author: Sam James <sam@xxxxxxxxxx>
Date:   Sat Jan 28 19:23:54 2023 +0100

    lib/ fix pkgconfig dir

    Signed-off-by: Sam James <sam@xxxxxxxxxx>
    Signed-off-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>

Can I just take a moment to vent about this some more.
The change is, in the words of another Linux developer, utter garbage.
${libdir} contains ${prefix} and did so for eternities.

The commit message is utter garbage too, because it does not
even try to make an argument to even _have_ the change in the
first place. Allowing such an underdocumented change is a
failure in the review process itself.

[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux