On Tue, Sep 19, 2023 at 02:30:38PM +0200, Thomas Haller wrote: > On Tue, 2023-09-19 at 14:18 +0200, Pablo Neira Ayuso wrote: > > Hi Thomas, > > > > On Tue, Sep 19, 2023 at 01:28:03PM +0200, Thomas Haller wrote: > > > It's not obvious that two enum values are missing (or why). > > > Explicitly > > > set the values to NULL, so we can see this more easily. > > > > I think this is uncovering a bug with these selectors. > > > > When concatenations are used, IIRC the delinerize path needs this. > > > > TYPE_CT_EVENTBIT does not need this, because this is a statement to > > globally filter ctnetlink events events. > > > > But TYPE_CT_LABEL is likely not working fine with concatenations. > > > > Let me take a closer look. > > Hi Pablo, > > Thank you. > > FYI, I have a patch with a unit test that performs some consistency > checks of the "datatypes" array. Only TYPE_CT_LABEL + TYPE_CT_EVENTBIT > are missing. > > You don't need to write a test about that. The test is however on top > of "no recursive make" patches, which I will resent at a later time. Thanks, I posted the fixes without unit tests: https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230919161254.640998-1-pablo@xxxxxxxxxxxxx/ https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230919161825.643827-1-pablo@xxxxxxxxxxxxx/
