On Fri, 2023-09-08 at 12:22 +0200, Florian Westphal wrote: > Thomas Haller <thaller@xxxxxxxxxx> wrote: > > These files are generated by running `./tests/shell/run-tests.sh - > > g`. > > Commit the .nodump files to git. > > > > The point is that we can in the future run `./tests/shell/run- > > tests.sh > > -g` and don't get an abundance of irrelevant dump files generated. > > > > This raises the question, whether some of these tests should > > actually > > have their ruleset compared against a .nft file. But this is > > nothing > > new and not prevented by this change. The change merely expresses > > in > > clear way that those tests are (currently) meant not to have .nft > > files. > > I think it would be preferrable to have a patch 2/3 that first adds > new .nft dump files for all tests where the output is stable, and > then > only add the .nodump files (this patch) for those where dump > validation > cannot work. > > I suspect that most will pass as expected. > Even an empty dump file can be useful because this would catch > (unlikely) bugs with delete/flush failure. > > We could simplify some scripts later on, some of the no-dump scripts > manually validate output, that isn't needed anymore after this. > Makes sense. Will do. Thomas
