On Mon, 2023-09-04 at 10:53 +0200, Florian Westphal wrote: > Thomas Haller <thaller@xxxxxxxxxx> wrote: > > > > > > But why this "nft -f" specific detection? Why not just executable > > scripts? > > Because I want it to be simple, It does not seem "simple[r]" to me. The approach requires extra infrastructure in run-test.sh, while being less flexible. > I could do that, but I don't see the need for arbitrary scripts so > far. When building without JSON support, various tests fail, but should be skipped. Could we detect JSON support via .nft files? Would we drop then a JSON .nft file and change the check call to `nft --check -j`?). Or maybe detection of JSON support needs to be a shell script (doing `ldd "$NFT_REAL" | greq libjansson`)? In that case, we would have features-as-shell-scripts very soon. Thomas
