Re: [PATCH nft v3 00/11] tests/shell: allow running tests as

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2023-09-05 at 13:09 +0200, Florian Westphal wrote:
> Thomas Haller <thaller@xxxxxxxxxx> wrote:
> > Ch;anges to v3:
> 
> I was about to apply this but 10 tests now fail for me because they
> no longer execute as real root and hit the socket buffer limits.
> 
> Please fix this, the default needs to be 'all tests pass',
> i.e. use plain 'unshare -n' by default.
> 
> I'll leave it up to you if you want to automatically go with
> unpriv netns if the script is invoked as non-root user or via
> env/cmdline switch.
> 
> At least one failure isn't your fault, the blame is
> with a shortcut check in sets/0043concatenated_ranges_0, so the test
> never execeuted fully in the past. I will try
> to figure out when this got broken :/
> 

hi,

yes, I noticed. Sorry about that.

Please see v4. That works well for me.


A major benefit IMO (which doesn't become clear from the commit
messages) is the result data in "/tmp/nft-test.latest". Have a look
there. And try the new "-j" option. And of course, try without root.

Thanks
Thomas





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux