expr_free() already handles NULL pointer, remove redundant check. Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> --- src/netlink_delinearize.c | 3 +-- src/rule.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c index 1121f730ffa7..bde783bdf4ad 100644 --- a/src/netlink_delinearize.c +++ b/src/netlink_delinearize.c @@ -83,8 +83,7 @@ static void netlink_set_register(struct netlink_parse_ctx *ctx, return; } - if (ctx->registers[reg] != NULL) - expr_free(ctx->registers[reg]); + expr_free(ctx->registers[reg]); ctx->registers[reg] = expr; } diff --git a/src/rule.c b/src/rule.c index 07b95a993275..35f6d8f28aee 100644 --- a/src/rule.c +++ b/src/rule.c @@ -193,8 +193,8 @@ void set_free(struct set *set) if (--set->refcnt > 0) return; - if (set->init != NULL) - expr_free(set->init); + + expr_free(set->init); if (set->comment) xfree(set->comment); handle_free(&set->handle); -- 2.30.2
