On Mon, Aug 28, 2023 at 05:33:01PM +0200, Thomas Haller wrote: > On Mon, 2023-08-28 at 17:08 +0200, Pablo Neira Ayuso wrote: > > On Mon, Aug 28, 2023 at 04:43:58PM +0200, Thomas Haller wrote: > > > > > > + _NFT_PRAGMA_WARNING_DISABLE("-Wformat-nonliteral") > > > > Maybe simply -Wno-format-nonliteral turn off in Clang so there is no > > need for this PRAGMA in order to simplify things. > > "-Wformat-nonliteral" seems a useful warning. I would rather not > disable it at a larger scale. > > Gcc also supports "-Wformat-nonliteral" warning, but for some reason it > does not warn here (also not, when I pass "-Wformat=2"). I don't > understand why that is. Can you see any other way to fix this clang compilation eror without this pragma? What makes clang unhappy with this code?