[PATCH conntrack-tools 0/4] Fixes for yacc parser compilation warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Certain classes of compiler warnings have in the past been disabled for
the sources generated by yacc and flex because "yacc and lex generate
dirty code", to quote the comment in the Makefile.  However, even if
this may have been the case at one time, currently none of the warnings
being suppressed relate to generated code.

The number of disabled classes was reduced last year:

  https://lore.kernel.org/netfilter-devel/20221124100804.25674-1-pablo@xxxxxxxxxxxxx/#r

This patch-set fixes the remaining warnings.

* Patch 1 improves the formatting of src/Makefile.am a bit.
* Patch 2 removes the `-Wno-*` flags.
* Patches 3 & 4 fix the resulting warnings.

Jeremy Sowden (4):
  build: reformat and sort `conntrack_LDADD` and `conntrackd_SOURCES`
  build: stop suppressing warnings for generated sources
  read_config_yy: correct `yyerror` prototype
  read_config_yy: correct arguments passed to `inet_aton`

 src/Makefile.am      | 80 +++++++++++++++++++++++++++++++++-----------
 src/read_config_yy.y | 30 ++++++++++++-----
 2 files changed, 81 insertions(+), 29 deletions(-)

-- 
2.40.1




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux