Re: [nft PATCH] tests: shell: Review test-cases for destroy command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 03, 2023 at 12:45:14AM +0200, Fernando F. Mancera wrote:
> Thanks Phil, LGTM. Just one comment:
> 
> On 01/08/2023 13:42, Phil Sutter wrote:
> > Having separate files for successful destroy of existing and
> > non-existing objects is a bit too much, just combine them into one.
> > 
> > While being at it:
> > 
> > * Check that deleted objects are actually gone
> 
> I think that is done automatically with the expected ruleset.. isn't? If 
> not, what is the purpose of having them?

Oh, I missed those entirely! I'll prepare a v2 dropping the manual
checks and deleting the leftovers.

Thanks, Phil



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux