Re: [PATCH iptables] nft-bridge: pass context structure to ops->add() to improve anonymous set support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 12, 2023 at 11:59:12AM +0200, Pablo Neira Ayuso wrote:
[...]
> diff --git a/iptables/nft.c b/iptables/nft.c
> index 1cb104e75ccc..59e3fa7079c4 100644
> --- a/iptables/nft.c
> +++ b/iptables/nft.c
> @@ -1154,7 +1154,8 @@ gen_lookup(uint32_t sreg, const char *set_name, uint32_t set_id, uint32_t flags)
>  #define NFT_DATATYPE_ETHERADDR	9
>  
>  static int __add_nft_among(struct nft_handle *h, const char *table,
> -			   struct nftnl_rule *r, struct nft_among_pair *pairs,
> +			   struct nft_rule_ctx *ctx, struct nftnl_rule *r,
> +			   struct nft_among_pair *pairs,
>  			   int cnt, bool dst, bool inv, bool ip)
>  {
>  	uint32_t set_id, type = NFT_DATATYPE_ETHERADDR, len = ETH_ALEN;

Is there something missing here? Neither add_nft_among() nor
__add_nft_among() use the new parameter. Or is this left over from a
previous version of the fix?

Cheers, Phil



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux