Re: [lvc-project] [PATCH] netfilter: ebtables: remove unnecessary NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/20/23 19:38, Florian Westphal wrote:
Igor Artemiev <Igor.A.Artemiev@xxxxxxx> wrote:
In ebt_do_table() 'private->chainstack' cannot be NULL
and the 'cs' pointer is dereferenced below, so it does not make
sense to compare 'private->chainstack' with NULL.
?  Why do you think that?

The 'cs' pointer is dereferenced below without checking, as it is assumed to always be initialized with 'private->chainstack[smp_processor_id()]'.
+	cs = private->chainstack[smp_processor_id()];
Looks like NULL deref to me.  Did you test this?

No, I didn't test this.

Thanks,
Igor




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux