Re: [iptables PATCH] xshared: fix memory leak in should_load_proto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jan,

On Tue, May 30, 2023 at 06:11:09PM +0200, Jan Engelhardt wrote:
[...]
> After 13 years, the code I once wrote feels weird. In essence, find_proto is
> called twice, but that should not be necessary because cs->proto_used already
> tracks whether this was done.
> [e.g. use `iptables -A INPUT -p tcp --dport 25 --unrecognized` to trigger]
> 
> Could someone cross check my alternative proposal I have below?

Thanks for the fix! Patch applied with minor subject and whitespace
fixes.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux