On Sat, Apr 01, 2023 at 12:43:04PM +0100, Jeremy Sowden wrote: > On 2023-03-31, at 22:36:01 +0000, Alyssa Ross wrote: > > If building statically, with libpcap built with libnl support, linking > > will fail, as the compiler won't be able to find the libnl symbols > > since static libraries don't contain dependency information. To fix > > this, use pkg-config to find the flags for linking libpcap, since the > > pkg-config files contain the neccesary dependency information. > ^^^^^^^^^ > "necessary" > > > Signed-off-by: Alyssa Ross <hi@xxxxxxxxx> > > LGTM. The only thing I would say is that pkg-config support was added > to libpcap comparatively recently (2018). When I made similar changes > to ulogd2 last year, I added a fall-back to pcap-config: > > https://git.netfilter.org/ulogd2/commit/?id=be4df8f66eb843dc19c7d1fed7c33fd7a40c2e21 That's quite a lot of extra code. Is it likely that people will want to build a version of iptables that is five years newer than their libpcap?
Attachment:
signature.asc
Description: PGP signature
