> -----Original Message----- > From: Jan Engelhardt <jengelh@xxxxxxx> > Sent: Thursday, 30 March 2023 13:51 > To: Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx> > Cc: netfilter-devel@xxxxxxxxxxxxxxx; Phil Sutter <phil@xxxxxx>; Pablo Neira > Ayuso <pablo@xxxxxxxxxxxxx>; Florian Westphal <fw@xxxxxxxxx> > Subject: Re: [RFC PATCH] nft: autocomplete for libreadline > > > On Thursday 2023-03-30 13:25, Sriram Yagnaraman wrote: > > >-libnftables_LIBVERSION=2:0:1 > >+libnftables_LIBVERSION=3:0:1 > > ^ This looks very much incorrect. I confess that I have no idea how this versioning works. I was unable to add the new libnftables API without changing this number. Please advise what I should use. > > >--- a/include/nftables/libnftables.h > >+++ b/include/nftables/libnftables.h > >+char **nft_get_expected_tokens(struct nft_ctx *nft, const char *line, const > char *text); > >--- a/include/parser.h > >+++ b/include/parser.h > >+extern char **expected_matches (struct nft_ctx *nft, struct parser_state > *state, > >+ const char *text);