Re: [PATCH nftables] exthdr: add boolean DCCP option matching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023-03-28, at 17:27:21 +0200, Florian Westphal wrote:
> Jeremy Sowden <jeremy@xxxxxxxxxx> wrote:
> > Iptables supports the matching of DCCP packets based on the presence
> > or absence of DCCP options.  Extend exthdr expressions to add this
> > functionality to nftables.
> > 
> > Link: https://bugzilla.netfilter.org/show_bug.cgi?id=930
> > Signed-off-by: Jeremy Sowden <jeremy@xxxxxxxxxx>
> 
> LGTM, thanks.

Cool.  I've just spotted a data-type ref-count bug.  In `dccp_init_raw`:

  expr->dtype = &boolean_type;

should be:

  datatype_set(expr, &boolean_type);

I'll send a new version with that fixed.

I think there are a few more instances of this sort, so I'll send a
follow-up patch for those.

J.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux