Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on horms-ipvs/master] [also build test ERROR on linus/master v6.3-rc3 next-20230322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/eric_sage-apple-com/netfilter-nfnetlink_queue-enable-classid-socket-info-retrieval/20230323-073405 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master patch link: https://lore.kernel.org/r/20230322223329.48949-1-eric_sage%40apple.com patch subject: [PATCH] netfilter: nfnetlink_queue: enable classid socket info retrieval config: m68k-defconfig (https://download.01.org/0day-ci/archive/20230323/202303231242.QaYElp9P-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/c28410a18b276a059551ce4ffad5d3721ea8cbf5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review eric_sage-apple-com/netfilter-nfnetlink_queue-enable-classid-socket-info-retrieval/20230323-073405 git checkout c28410a18b276a059551ce4ffad5d3721ea8cbf5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/netfilter/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303231242.QaYElp9P-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): net/netfilter/nfnetlink_queue.c: In function 'nfqnl_put_sk_classid': >> net/netfilter/nfnetlink_queue.c:312:9: error: implicit declaration of function 'sock_cgroup_classid' [-Werror=implicit-function-declaration] 312 | sock_cgroup_classid(&entskb->sk->sk_cgrp_data); | ^~~~~~~~~~~~~~~~~~~ net/netfilter/nfnetlink_queue.c:312:30: error: 'entskb' undeclared (first use in this function) 312 | sock_cgroup_classid(&entskb->sk->sk_cgrp_data); | ^~~~~~ net/netfilter/nfnetlink_queue.c:312:30: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors vim +/sock_cgroup_classid +312 net/netfilter/nfnetlink_queue.c 303 304 static int nfqnl_put_sk_classid(struct sk_buff *skb, struct sock *sk) 305 { 306 u32 classid; 307 308 if (!sk_fullsock(sk)) 309 return 0; 310 311 read_lock_bh(sk->sk_callback_lock); > 312 sock_cgroup_classid(&entskb->sk->sk_cgrp_data); 313 if (nla_put_be32(skb, NFQA_CLASSID, htonl(classid))) 314 goto nla_put_failure; 315 read_unlock_bh(sk->sk_callback_lock); 316 return 0; 317 318 nla_put_failure: 319 read_unlock_bh(sk->sk_callback_lock); 320 return -1; 321 } 322 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
