RE: [PATCH nft v2] meta: introduce broute expression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Florian Westphal <fw@xxxxxxxxx>
> Sent: Friday, 24 February 2023 11:49
> To: Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx>
> Cc: netfilter-devel@xxxxxxxxxxxxxxx; Florian Westphal <fw@xxxxxxxxx>; Pablo
> Neira Ayuso <pablo@xxxxxxxxxxxxx>
> Subject: Re: [PATCH nft v2] meta: introduce broute expression
> 
> Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx> wrote:
> > nft userspace tool support broute meta statment proposed in [1].
> >
> > [1]:
> > https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230224095
> > 251.11249-1-sriram.yagnaraman@xxxxxxxx/
> 
> LGTM.
> 
> Can you make a followup patch that adds a test case to
> tests/py/bridge/meta.t
> 
> and a new test file, e.g.
> tests/py/bridge/redirect.t ?
> 
> First one is expected to fail (only input is tested), but second one should pass.
> 
> Make sure this works with -j (json as well).
> 
> Thanks.

Thank you for the reviews.
I have now added the tests in v3, I hope I have got them right.





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux